Skip to content

Nebula: Improved toasts in move funds page #7307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 48 additions & 44 deletions apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,6 @@ function SendFunds(props: {
activeAccount: Account;
}) {
const { tokens, chain, receiverAddress } = params;
toast.loading(`Sending ${tokens.length} Tokens`);

const transactions = tokens.map(({ token, amount }) => {
return getTokenTransferTransaction({
Expand All @@ -289,18 +288,19 @@ function SendFunds(props: {
});
});

try {
await sendBatchTransactions.mutateAsync(transactions);
toast.success("Tokens sent successfully", {
duration: 10000,
});
} catch (e) {
toast.error("Failed to send tokens", {
description: parseError(e),
duration: 10000,
});
console.error(e);
}
const txPromise = sendBatchTransactions.mutateAsync(transactions);
toast.promise(txPromise, {
loading: `Sending ${tokens.length} tokens`,
success: `${tokens.length} tokens sent successfully`,
error: (result) => {
return {
message: "Failed to send tokens. Please try again",
description: parseError(result),
};
},
});

await txPromise;
}

async function handleSingleSubmit(params: {
Expand All @@ -321,36 +321,36 @@ function SendFunds(props: {
receiverAddress,
});

toast.loading(`Sending Token ${token.name}`);
await sendAndConfirmTransaction.mutateAsync(tx);
const txPromise = sendAndConfirmTransaction.mutateAsync(tx);

toast.success(`${token.name} sent successfully`, {
duration: 10000,
toast.promise(txPromise, {
loading: `Sending Token ${token.name}`,
success: `${token.name} sent successfully`,
error: (result) => {
return {
message: `Failed to send ${token.name}. Please try again`,
description: parseError(result),
};
},
});

await txPromise;

queryClient.invalidateQueries({
queryKey: ["walletBalance"],
});

successCount++;
} catch (e) {
toast.error(`Failed to send ${token.name}`, {
description: parseError(e),
duration: 10000,
});
} catch {
// no op
}
}

if (tokens.length > 1) {
if (successCount === tokens.length) {
toast.success("All tokens sent successfully", {
id: "batch-send",
duration: 10000,
});
toast.success("All tokens sent successfully");
} else {
toast.error(`Failed to send ${tokens.length - successCount} tokens`, {
id: "batch-send",
duration: 10000,
});
toast.error(`Failed to send ${tokens.length - successCount} tokens`);
}
}
}
Expand All @@ -374,20 +374,24 @@ function SendFunds(props: {
// eslint-disable-next-line no-restricted-syntax
const chain = defineChain(values.chainId);

if (activeAccount.sendBatchTransaction) {
await handleBatchSubmit({
tokens: validTokens,
chain,
activeAccount,
receiverAddress: values.receiverAddress,
});
} else {
await handleSingleSubmit({
tokens: validTokens,
chain,
activeAccount,
receiverAddress: values.receiverAddress,
});
try {
if (activeAccount.sendBatchTransaction) {
await handleBatchSubmit({
tokens: validTokens,
chain,
activeAccount,
receiverAddress: values.receiverAddress,
});
} else {
await handleSingleSubmit({
tokens: validTokens,
chain,
activeAccount,
receiverAddress: values.receiverAddress,
});
}
} catch {
// no op
}

queryClient.invalidateQueries({
Expand Down
Loading