-
Notifications
You must be signed in to change notification settings - Fork 559
[Experiment] Remove clientId from serverThirdwebClient #7203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] Remove clientId from serverThirdwebClient #7203
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 05-28-_tool-4621_new_erc20_public_contract_page #7203 +/- ##
===================================================================================
- Coverage 55.69% 55.67% -0.03%
===================================================================================
Files 904 904
Lines 58391 58391
Branches 4129 4116 -13
===================================================================================
- Hits 32522 32510 -12
- Misses 25761 25775 +14
+ Partials 108 106 -2
🚀 New features to boost your workflow:
|
size-limit report 📦
|
943f864
to
7a99c1d
Compare
PR-Codex overview
This PR introduces enhancements to the
thirdweb-client
andthirdweb-server
configurations, adds a newDecimalInput
component for better numeric input handling, and refines theClaimTokenCardUI
to utilize this component. It also updates the logic for handling token quantities.Detailed summary
clientId
andtype
parameters togetConfiguredThirdwebClient
.DecimalInput
component for improved numeric input handling.DecimalInput
implementation inTokenSaleSection
with the new component.ClaimTokenCardUI
to useDecimalInput
for quantity input.quantity
inClaimTokenCardUI
.