Skip to content

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 19, 2025


PR-Codex overview

This PR introduces a new utility function to retrieve installed wallets and updates a test to address an IPFS error. It also exports the new utility function from the mipdStore.js file.

Detailed summary

  • Added getInstalledWallets() function to return a list of installed wallets.
  • Exported getInstalledWallets from mipdStore.js.
  • Updated test in deploy-modular-core.test.ts to mark it as a TODO due to an IPFS error.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 2:05am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 2:05am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 2:05am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 2:05am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 2:05am

Copy link

changeset-bot bot commented May 19, 2025

🦋 Changeset detected

Latest commit: 42bb5a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review May 19, 2025 01:43
@joaquim-verges joaquim-verges requested review from a team as code owners May 19, 2025 01:43
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 19, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented May 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 183 ms (+162% 🔺) 1.3 s
thirdweb (cjs) 194.07 KB (0%) 3.9 s (0%) 385 ms (+43.44% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 65 ms (+1386.73% 🔺) 178 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 24 ms (+1663.14% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 102 ms (+790.33% 🔺) 492 ms

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.30%. Comparing base (fdd3441) to head (42bb5a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/thirdweb/src/wallets/injected/mipdStore.ts 33.33% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7077      +/-   ##
==========================================
- Coverage   55.49%   55.30%   -0.20%     
==========================================
  Files         909      909              
  Lines       58406    58412       +6     
  Branches     4072     4063       -9     
==========================================
- Hits        32415    32306     -109     
- Misses      25886    26001     +115     
  Partials      105      105              
Flag Coverage Δ
packages 55.30% <33.33%> (-0.20%) ⬇️
Files with missing lines Coverage Δ
...ackages/thirdweb/src/wallets/injected/mipdStore.ts 39.39% <33.33%> (-1.35%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit c61e258 into main May 19, 2025
23 of 24 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Expose_getInstalledWallets_utility branch May 19, 2025 02:07
@joaquim-verges joaquim-verges mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant