Skip to content

[Dashboard] Use testnet chains from useAllChainsData instead of hardcoded list #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 16, 2025


PR-Codex overview

This PR updates the SendTestTransaction component to use a dynamic list of chain IDs from the useAllChainsData hook instead of a hardcoded list. This enhances flexibility and maintainability by allowing the component to adapt to changes in available chains.

Detailed summary

  • Removed hardcoded chain IDs from SingleNetworkSelector.
  • Added useAllChainsData hook to fetch dynamic chain data.
  • Updated chainIds prop to filter and map chain IDs based on testnet status and stack type.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 10:27am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 16, 2025 10:27am
login ⬜️ Skipped (Inspect) May 16, 2025 10:27am
thirdweb_playground ⬜️ Skipped (Inspect) May 16, 2025 10:27am
wallet-ui ⬜️ Skipped (Inspect) May 16, 2025 10:27am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 16, 2025 10:14 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 16, 2025 10:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 16, 2025 10:14 Inactive
Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: 263ef04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 16, 2025 10:14 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 16, 2025
Copy link
Member Author

joaquim-verges commented May 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the _Dashboard_Use_testnet_chains_from_useAllChainsData_instead_of_hardcoded_list branch from a39c0b6 to 263ef04 Compare May 16, 2025 10:15
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 16, 2025 10:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 16, 2025 10:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 16, 2025 10:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 16, 2025 10:15 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review May 16, 2025 10:18
@joaquim-verges joaquim-verges requested review from a team as code owners May 16, 2025 10:18
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (dd8530a) to head (263ef04).
Report is 1 commits behind head on _Engine_Add_chain_ID_13337_to_test_transaction_options.

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           _Engine_Add_chain_ID_13337_to_test_transaction_options    #7067   +/-   ##
=======================================================================================
  Coverage                                                   55.50%   55.50%           
=======================================================================================
  Files                                                         909      909           
  Lines                                                       58402    58402           
  Branches                                                     4071     4071           
=======================================================================================
  Hits                                                        32415    32415           
  Misses                                                      25882    25882           
  Partials                                                      105      105           
Flag Coverage Δ
packages 55.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 129 ms (+85.87% 🔺) 1.3 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 308 ms (+13.05% 🔺) 4.2 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 37 ms (+554.91% 🔺) 151 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 26 ms (+1582.67% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 60 ms (+250.4% 🔺) 450 ms

@joaquim-verges joaquim-verges merged commit 51d6c67 into _Engine_Add_chain_ID_13337_to_test_transaction_options May 16, 2025
22 of 23 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Use_testnet_chains_from_useAllChainsData_instead_of_hardcoded_list branch May 16, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant