Move Contract page components to app router folder #2 (no code change) #5073

MananTank · 2024-10-17T20:52:58Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on refactoring the code structure by reorganizing the import paths and updating component references across various files in the apps/dashboard/src directory. It improves modularity and maintainability of the codebase.

Detailed summary

Updated import paths for several components in page.tsx files to use relative paths.
Renamed and relocated components such as ContractSplitPage, ContractProposalsPage, and ContractPermissionsPage.
Modified DistributeButton and SolidityInput imports to reflect new paths.
Removed unnecessary imports and organized hooks in the permissions components.
Adjusted the import of PrimaryDashboardButton to a new location in layout.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-17T20:53:01Z

⚠️ No Changeset found

Latest commit: 00a6a56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-17T20:53:03Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel · 2024-10-17T20:53:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 17, 2024 9:08pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 17, 2024 9:08pm
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 17, 2024 9:08pm
wallet-ui	⬜️ Skipped (Inspect)	Oct 17, 2024 9:08pm

MananTank · 2024-10-17T20:53:12Z

Move Contract page components to app router folder #2 (no code change) #5073 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

github-actions · 2024-10-17T20:56:33Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.81 KB (0%)	857 ms (0%)	581 ms (-3.66% 🔽)	1.5 s
thirdweb (cjs)	102.66 KB (0%)	2.1 s (0%)	1.5 s (+20.4% 🔺)	3.5 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	38 ms (-47.53% 🔽)	135 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	144 ms (+1454.47% 🔺)	154 ms
thirdweb/react (minimal + tree-shaking)	17.36 KB (0%)	348 ms (0%)	308 ms (+200.85% 🔺)	656 ms

codecov · 2024-10-17T20:56:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (7855c3e) to head (00a6a56).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5073   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54728    54728           
  Branches     3954     3954           
=======================================
  Hits        24791    24791           
  Misses      29246    29246           
  Partials      691      691

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 7855c3e
packages	`40.24% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

graphite-app · 2024-10-17T21:03:04Z

Merge activity

Oct 17, 5:03 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 17, 5:09 PM EDT: A user merged this pull request with the Graphite merge queue.

#5073) ## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR refactors the structure of the dashboard application, changing the import paths for several components and pages to a more localized format. It also moves certain components related to contract management and permissions to new locations. ### Detailed summary - Updated import paths for various pages and components to local paths. - Moved `ContractSplitPage` to `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/split/ContractSplitPage.tsx`. - Moved `DistributeButton` to `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/split/components/distribute-button.tsx`. - Moved `ContractProposalsPage` to `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/proposals/ContractProposalsPage.tsx`. - Moved `ContractEditModulesPage` to `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/ContractEditModulesPage.tsx`. - Moved `ContractPermissionsPage` to `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/permissions/ContractPermissionsPage.tsx`. - Moved `ContractExplorerPage` to `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/explorer/ContractExplorerPage.tsx`. - Moved `ContractSettingsPage` to `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/settings/ContractSettingsPage.tsx`. - Updated import statements in `events-feed.tsx` and `permissions/index.tsx` to reflect new paths. - Adjusted type imports in various components to align with the new structure. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 20:53 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 20:53 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 20:53 Inactive

MananTank marked this pull request as ready for review October 17, 2024 20:53

MananTank requested review from jnsdls and joaquim-verges as code owners October 17, 2024 20:53

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 17, 2024

jnsdls approved these changes Oct 17, 2024

View reviewed changes

vercel bot deployed to Preview – thirdweb-www October 17, 2024 21:02 View deployment

jnsdls force-pushed the 10-18-move_contract_page_components_to_app_router_folder_2_no_code_change_ branch from 5d4ef44 to 00a6a56 Compare October 17, 2024 21:03

vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 21:03 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 21:03 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 21:03 Inactive

vercel bot deployed to Preview – thirdweb-www October 17, 2024 21:08 View deployment

graphite-app bot merged commit 00a6a56 into main Oct 17, 2024
31 checks passed

graphite-app bot deleted the 10-18-move_contract_page_components_to_app_router_folder_2_no_code_change_ branch October 17, 2024 21:09

vercel bot temporarily deployed to Production – thirdweb_playground October 17, 2024 21:09 Inactive

vercel bot temporarily deployed to Production – docs-v2 October 17, 2024 21:09 Inactive

vercel bot temporarily deployed to Production – wallet-ui October 17, 2024 21:09 Inactive

vercel bot deployed to Production – thirdweb-www October 17, 2024 21:19 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move Contract page components to app router folder #2 (no code change) #5073

Move Contract page components to app router folder #2 (no code change) #5073

Uh oh!

MananTank commented Oct 17, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 17, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 17, 2024

Uh oh!

vercel bot commented Oct 17, 2024 •

edited

Loading

Uh oh!

MananTank commented Oct 17, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 17, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 17, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 17, 2024 •

edited by jnsdls

Loading

Uh oh!

Uh oh!

Uh oh!

Move Contract page components to app router folder #2 (no code change) #5073

Move Contract page components to app router folder #2 (no code change) #5073

Uh oh!

Conversation

MananTank commented Oct 17, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

vercel bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Oct 17, 2024 • edited by jnsdls Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented Oct 17, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 17, 2024 •

edited

Loading

vercel bot commented Oct 17, 2024 •

edited

Loading

MananTank commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

codecov bot commented Oct 17, 2024 •

edited

Loading

graphite-app bot commented Oct 17, 2024 •

edited by jnsdls

Loading