Skip to content

[SDK] handle updating metadata for ERC1155Token contracts #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

joaquim-verges
Copy link
Member

Problem solved

Short description of the bug fixed or feature added

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:

@joaquim-verges joaquim-verges requested a review from a team February 29, 2024 03:27
Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: e64176c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges added this pull request to the merge queue Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (7d74d30) to head (e64176c).

Files Patch % Lines
packages/sdk/src/evm/core/classes/erc-1155.ts 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2369   +/-   ##
=======================================
  Coverage   66.91%   66.92%           
=======================================
  Files         293      293           
  Lines       11245    11250    +5     
  Branches     1562     1564    +2     
=======================================
+ Hits         7525     7529    +4     
  Misses       3085     3085           
- Partials      635      636    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 8d2811d Feb 29, 2024
@joaquim-verges joaquim-verges deleted the joaquim/edition_update_meta branch February 29, 2024 03:41
@jnsdls jnsdls mentioned this pull request Feb 28, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant