Skip to content

[react] remove const enums #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2024
Merged

[react] remove const enums #2354

merged 5 commits into from
Feb 28, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Feb 27, 2024

const enums are not being handled properly when creating a production build in next.js version < 13.5

@MananTank MananTank requested a review from a team as a code owner February 27, 2024 15:22
@MananTank MananTank requested a review from a team February 27, 2024 15:22
Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: e6c83df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@thirdweb-dev/react Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MananTank
Copy link
Member Author

/release-pr

@MananTank
Copy link
Member Author

/release-pr

@MananTank MananTank added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@MananTank MananTank enabled auto-merge February 27, 2024 18:16
@MananTank MananTank added this pull request to the merge queue Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (574f180) to head (e6c83df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2354   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files         293      293           
  Lines       11242    11242           
  Branches     1561     1561           
=======================================
  Hits         7522     7522           
  Misses       3085     3085           
  Partials      635      635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit cff6ef2 Feb 28, 2024
@MananTank MananTank deleted the mnn/no-const-enum branch February 28, 2024 19:17
@jnsdls jnsdls mentioned this pull request Feb 28, 2024
jnsdls added a commit that referenced this pull request Jun 19, 2024
* Fix upload button media not working

* format

* Update mint-form.tsx

Signed-off-by: Jonas Daniels <[email protected]>

---------

Signed-off-by: Jonas Daniels <[email protected]>
Co-authored-by: Jonas Daniels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants