Skip to content

[wallet, react] Add Magic Eden wallet #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Feb 24, 2024

Try: https://all-thirdweb-wallets.vercel.app


PR-Codex overview

This PR adds support for the Magic Eden wallet, including wallet IDs, locales, connectors, and UI components.

Detailed summary

  • Added magicEden wallet ID
  • Included Magic Eden wallet locales
  • Implemented Magic Eden wallet class and connector
  • Added Magic Eden wallet UI components

The following files were skipped due to too many changes: packages/wallets/src/evm/connectors/magic-eden/index.ts, packages/react/src/wallet/wallets/magicEden/magicEdenWallet.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kien-ngo kien-ngo requested a review from a team as a code owner February 24, 2024 13:23
@kien-ngo kien-ngo requested a review from a team February 24, 2024 13:23
Copy link

changeset-bot bot commented Feb 24, 2024

🦋 Changeset detected

Latest commit: 1872903

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@thirdweb-dev/react-core Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/react Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kien-ngo
Copy link
Contributor Author

/release-pr

@kien-ngo kien-ngo requested a review from MananTank February 24, 2024 13:50
@kien-ngo
Copy link
Contributor Author

@MananTank this was requested by Atif. Can you take a look? (should be similar to the xdefi one)

Ty good sir 🙏

@MananTank MananTank enabled auto-merge February 27, 2024 22:32
@MananTank
Copy link
Member

LGTM - @kien-ngo Thanks!

@MananTank MananTank disabled auto-merge February 27, 2024 22:32
@MananTank MananTank enabled auto-merge February 27, 2024 22:33
@MananTank MananTank added this pull request to the merge queue Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.92%. Comparing base (cc22fa8) to head (1872903).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2347   +/-   ##
=======================================
  Coverage   66.92%   66.92%           
=======================================
  Files         293      293           
  Lines       11250    11250           
  Branches     1564     1564           
=======================================
  Hits         7529     7529           
  Misses       3085     3085           
  Partials      636      636           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 73e34c0 Feb 29, 2024
@MananTank MananTank deleted the kien/add-magic-eden-wallet branch February 29, 2024 10:26
@jnsdls jnsdls mentioned this pull request Feb 29, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
New product grouping images

Signed-off-by: Juan Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants