Resolve implementation update #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fecb37b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
- Coverage 66.90% 66.88% -0.03%
==========================================
Files 293 293
Lines 11201 11209 +8
Branches 1553 1556 +3
==========================================
+ Hits 7494 7497 +3
- Misses 3075 3080 +5
Partials 632 632 ☔ View full report in Codecov by Sentry. |
kumaryash90
changed the title
| if (e instanceof Error) { | ||
| if ( | ||
| !e.message.includes( | ||
| `Contract at ${implementationAddress} does not exist on chain`, |
There was a problem hiding this comment.
can you explain this change? what do we return if that's the error we hit?
joaquim-verges
approved these changes
Feb 12, 2024
jnsdls
added a commit
that referenced
this pull request
Feb 14, 2024
jnsdls
added a commit
that referenced
this pull request
Jun 19, 2024
* refactor: Remove unused parameter * refactor: Remove unnecessary comment in useNftDrawerTabs.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveImplementationto return original address if implementation address returns 0x