Skip to content

Conversation

joaquim-verges
Copy link
Member

Problem solved

Short description of the bug fixed or feature added

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:

@joaquim-verges joaquim-verges requested a review from a team February 10, 2024 06:39
Copy link

changeset-bot bot commented Feb 10, 2024

🦋 Changeset detected

Latest commit: 7f4128c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges
Copy link
Member Author

/release-pr

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d33227a) 66.90% compared to head (7f4128c) 66.90%.
Report is 2 commits behind head on main.

Files Patch % Lines
packages/sdk/src/evm/lib/static-batch-rpc.ts 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2294   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files         293      293           
  Lines       11201    11202    +1     
  Branches     1553     1554    +1     
=======================================
+ Hits         7494     7495    +1     
  Misses       3075     3075           
  Partials      632      632           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnsdls jnsdls enabled auto-merge February 10, 2024 06:56
@jnsdls jnsdls added this pull request to the merge queue Feb 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2024
@joaquim-verges joaquim-verges added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 3137e45 Feb 14, 2024
@joaquim-verges joaquim-verges deleted the joaquim/batch_options branch February 14, 2024 00:46
@jnsdls jnsdls mentioned this pull request Feb 14, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* feat: superchain farcaster frame

* chore: frame images

* chore: cleanup

* chore: updates

* chore: update plan image

* chore: update pnpm lock yaml

* chore: replace frame to be on superchain page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants