[Wallets] Fix potential embedded wallet autoconnect race condition #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ca0d12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
jnsdls
added a commit
that referenced
this pull request
Jun 19, 2024
…inSlug (#1977) * refactor: Refactor contractInfo assignment and add null check for chainSlug * refactor: Remove unnecessary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
There was a potential code path that would attempt to get the signer after autoconnect where the user is not in the initialized state, resulting in getAddress returning the last saved address but the signer failing to initialize. Fixed that by enforcing that getUser() always returns a initialized user or throw, and syncing the getAddress() and getSigner() calls.
Changes made
How to test