Skip to content

Resolve: Deletion on mapping containing a struct-with-mapping #602 #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Resolve: Deletion on mapping containing a struct-with-mapping #602 #608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 57 additions & 3 deletions src/test/ContractPublisher.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,18 +232,42 @@ contract ContractPublisherTest is BaseTest, IContractPublisherData {
// );
// }

function test_unpublish() public {
function test_unpublish_state() public {
string memory contractId = "MyContract";

vm.prank(publisher);
vm.startPrank(publisher);
byoc.publishContract(
publisher,
contractId,
publishMetadataUri,
"publish URI 1",
compilerMetadataUri,
keccak256(type(MockCustomContract).creationCode),
address(0)
);
byoc.publishContract(
publisher,
contractId,
"publish URI 2",
compilerMetadataUri,
keccak256(type(MockCustomContract).creationCode),
address(0)
);
byoc.publishContract(
publisher,
contractId,
"publish URI 3",
compilerMetadataUri,
keccak256(type(MockCustomContract).creationCode),
address(0)
);

vm.stopPrank();

IContractPublisher.CustomContractInstance[] memory allCustomContractsBefore = byoc.getPublishedContractVersions(
publisher,
contractId
);
assertEq(allCustomContractsBefore.length, 3);

vm.prank(publisher);
byoc.unpublishContract(publisher, contractId);
Expand All @@ -257,6 +281,36 @@ contract ContractPublisherTest is BaseTest, IContractPublisherData {
assertEq(customContract.publishMetadataUri, "");
assertEq(customContract.bytecodeHash, bytes32(0));
assertEq(customContract.implementation, address(0));

IContractPublisher.CustomContractInstance[] memory allCustomContracts = byoc.getPublishedContractVersions(
publisher,
contractId
);

assertEq(allCustomContracts.length, 0);

vm.prank(publisher);
byoc.publishContract(
publisher,
contractId,
"publish URI 4",
compilerMetadataUri,
keccak256(type(MockCustomContract).creationCode),
address(0)
);

IContractPublisher.CustomContractInstance memory customContractRepublish = byoc.getPublishedContract(
publisher,
contractId
);

assertEq(customContractRepublish.contractId, contractId);
assertEq(customContractRepublish.publishMetadataUri, "publish URI 4");

IContractPublisher.CustomContractInstance[] memory allCustomContractsRepublish = byoc
.getPublishedContractVersions(publisher, contractId);

assertEq(allCustomContractsRepublish.length, 1);
}

// Deprecated
Expand Down