Skip to content

PlatformFee: Sync extensions in /upgradeable and non-upgradeable #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 16, 2023
Merged

PlatformFee: Sync extensions in /upgradeable and non-upgradeable #530

merged 6 commits into from
Oct 16, 2023

Conversation

kumaryash90
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...ntracts/prebuilts/signature-drop/SignatureDrop.sol 64.93% <ø> (ø)
contracts/extension/PlatformFee.sol 45.83% <50.00%> (+0.37%) ⬆️
contracts/extension/PrimarySale.sol 87.50% <50.00%> (-12.50%) ⬇️
contracts/extension/BurnToClaim.sol 0.00% <0.00%> (ø)
...acts/legacy-contracts/extension/PrimarySale_V1.sol 0.00% <0.00%> (ø)
contracts/extension/upgradeable/PlatformFee.sol 44.44% <0.00%> (-41.27%) ⬇️
...acts/legacy-contracts/extension/PlatformFee_V1.sol 4.54% <4.54%> (ø)

📢 Thoughts on this report? Let us know!.

@nkrishang nkrishang changed the title Sync extensions PlatformFee: Sync extensions in /upgradeable and non-upgradeable Oct 16, 2023
@nkrishang nkrishang enabled auto-merge (squash) October 16, 2023 20:45
@nkrishang nkrishang merged commit a64ca6b into main Oct 16, 2023
@nkrishang nkrishang deleted the yash/sync-extensions branch October 16, 2023 21:12
@kien-ngo kien-ngo mentioned this pull request Nov 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrishang nkrishang Awaiting requested review from nkrishang

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaryash90 @joaquim-verges @nkrishang