ADR0004: Justify extent of OOP in metadata model #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MADR that justifies why we want to add custom classes for complex tuf metadata attributes. Signed-off-by: Lukas Puehringer <[email protected]>
mnm678
approved these changes
Nov 30, 2020
|
💯 💯 In my own experience, it has been extremely useful to decouple the internal, higher-level representation of metadata from the data format themselves. Not only does this let you use different data formats with the same high-level representation, but it also lets you write better code that is independent of the data format (as should be the case). |
|
Thanks for making a strong case for this proposal, @trishankatdatadog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1133
Description of the changes being introduced by the pull request:
Add MADR that justifies why we want to add custom classes for complex tuf metadata attributes.
Please verify and check that the pull request fulfills the following
requirements: