ASoC: Intel: soc-acpi-ptl-match: add cs42l43_l3_cs35l56_2 support #5566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchian
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
Collaborator
|
@macchian in theory, we can use the default machine driver + function topology. What if you test without this PR? |
Author
The BIOS in customer projects currently only support Disco 1.0. So it doesn't have SDCA functions. |
bardliao
reviewed
Oct 29, 2025
| .link_mask = BIT(3) | BIT(2), | ||
| .links = ptl_cs42l43_l3_cs35l56_l2, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-ptl-cs42l43-l3-cs35l56-l2.tplg", |
Collaborator
There was a problem hiding this comment.
Maybe sof-ptl-cs42l43-agg-l3-cs35l56-l2.tplg to show that the cs42l43 is aggregated with cs35l56? It is possible that a cs42l43_l3_cs35l56_l2 but cs42l43 speaker is not used configuration will be used in the future.
macchian
force-pushed
the
dev-cs42l43-cs35l56
branch
from
8e9eeae to
5ee1052
Compare
This patch adds the aggregated mode support: cs42l43 codec with left and right tweeters on soundwire link 3, cs35l56 left and right woofers on soundwire link 2. Signed-off-by: Mac Chiang <[email protected]>
This patch adds Cirrus codec internal speaker configuration to support the cs42l43_l3_cs35l56_l2 machine. Signed-off-by: Mac Chiang <[email protected]>
bardliao
previously approved these changes
Nov 3, 2025
bardliao
reviewed
Nov 3, 2025
Collaborator
There was a problem hiding this comment.
nitpick: maybe BIT(2) | BIT(3) to align with others?
macchian
force-pushed
the
dev-cs42l43-cs35l56
branch
from
5ee1052 to
d6ebbfb
Compare
bardliao
approved these changes
Nov 4, 2025
Collaborator
|
@simontrimmer Could you review this PR? |
simontrimmer
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the aggregated mode support:
cs42l43 codec with left and right tweeter speakers on soundwire link 3,
cs35l56 left and right woofer speakers on soundwire link 2.