Skip to content

ASOC: SOF: topology: Fix effect enum and eq size #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juimonen wants to merge 1 commit into from
Closed

ASOC: SOF: topology: Fix effect enum and eq size #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/uapi/sound/sof-ipc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,21 +724,21 @@ struct sof_ipc_comp_tone {
struct sof_ipc_comp_eq_fir {
Copy link
Collaborator

@ranj063 ranj063 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juimonen I dont see the size and data members in the same structure in the firmware. Is there a pull request pending for it?

Copy link
Collaborator

@ranj063 ranj063 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops..sorry I just updated my repo. Looks good!

struct sof_ipc_comp comp;
struct sof_ipc_comp_config config;
int32_t size;
uint32_t size;
unsigned char data[0];
} __attribute__((packed));

/* IIR equalizer component */
struct sof_ipc_comp_eq_iir {
struct sof_ipc_comp comp;
struct sof_ipc_comp_config config;
int32_t size;
uint32_t size;
unsigned char data[0];
} __attribute__((packed));

/** \brief Types of EFFECT */
enum sof_ipc_effect_type {
SOF_EFFECT_INTEL_NONE = 0, /**< None */
SOF_EFFECT_NONE = 0, /**< None */
SOF_EFFECT_INTEL_EQFIR, /**< Intel FIR */
SOF_EFFECT_INTEL_EQIIR, /**< Intel IIR */
};
Expand Down
2 changes: 1 addition & 1 deletion sound/soc/sof/topology.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ static enum sof_ipc_effect_type find_effect(const char *name)
return sof_effects[i].type;
}

return SOF_EFFECT_INTEL_NONE;
return SOF_EFFECT_NONE;
}

/*
Expand Down