Rewrite ENC to use classes #55
Draft
+305
−325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrite uses classes to coherently group functionality. It attempts to separate out the actual client logic into a ForemanClient class. Then around that it wraps methods to push and watch as well as the ENC. Uploading is rewritten to always use the same logic, regardless of whether it's single threaded or parallel. Single threaded just spawns a single thread. This also has the advantage of being able to reuse HTTP connection instances, possibly leading to higher throughput since it doesn't have to establish fresh HTTP(S) connections for every request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite uses classes to coherently group functionality. It attempts to separate out the actual client logic into a ForemanClient class. Then around that it wraps methods to push and watch as well as the ENC.
Uploading is rewritten to always use the same logic, regardless of whether it's single threaded or parallel. Single threaded just spawns a single thread. This also has the advantage of being able to reuse HTTP connection instances, possibly leading to higher throughput since it doesn't have to establish fresh HTTP(S) connections for every request.
Right now this is completely untested, but it was sparked by comments from @bastelfreak.