Skip to content

Fix migrate from enzyme link in the sidebar #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2020
Merged

Fix migrate from enzyme link in the sidebar #601

merged 4 commits into from
Sep 10, 2020

Conversation

m98
Copy link
Member

@m98 m98 commented Sep 9, 2020

In this comment, @MatanBobi said the issue with the "Migrate from Enzyme" page which is not showing in the sidebar would be resolved if we change its name in the sidebar (to be equal to the id which is defined in the migrate-from-enzyme.md )

@MatanBobi
Copy link
Member

MatanBobi commented Sep 9, 2020 •
edited
Loading

Looks like it's there now :)
I would maybe change the id to be migrate-from-enzyme since migrate is too generic..
https://deploy-preview-601--testing-library.netlify.app/docs/react-testing-library/migrate
image

@m98
Copy link
Member Author

m98 commented Sep 9, 2020

@MatanBobi Thank you for your comment

I just updated the id to migrate-from-enzyme and also access to migrate-from-enzyme in siderbars.json

Can you please verify the output is still correct?

@MatanBobi
Copy link
Member

@MatanBobi Thank you for your comment

I just updated the id to migrate-from-enzyme and also access to migrate-from-enzyme in siderbars.json

Can you please verify the output is still correct?

It's indeed there :)
https://deploy-preview-601--testing-library.netlify.app/docs/react-testing-library/migrate-from-enzyme
You can also have a look at it yourself btw, the pipeline creates a netlify deploy preview, just click on the details :)
image

I also recommend testing it locally..

@nickserv nickserv linked an issue Sep 9, 2020 that may be closed by this pull request
Clicking the "Next ->" button on /react-testing-library/api redirects to a page that doesn't exist #608
Closed
@nickserv nickserv merged commit c4ee7d0 into master Sep 10, 2020
@nickserv nickserv deleted the m98-patch-1 branch September 10, 2020 00:01
@mrantry
Copy link

mrantry commented Sep 10, 2020

Thank you @nickmccurdy <3

This was referenced Sep 10, 2020
Closed
Closed
@testing-library testing-library deleted a comment from allcontributors bot Sep 10, 2020
@testing-library testing-library deleted a comment from allcontributors bot Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickserv nickserv nickserv approved these changes

@MatanBobi MatanBobi MatanBobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking the "Next ->" button on /react-testing-library/api redirects to a page that doesn't exist
4 participants
@m98 @MatanBobi @mrantry @nickserv