Skip to content

Docs: Updated UI of Page[Help] #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

JoyelJohny
Copy link
Contributor

Before:
Screenshot 2023-10-20 at 19-08-46 Testing Library Testing Library

After:
Screenshot 2023-10-20 at 19-07-25 Testing Library Testing Library

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 9233ff7
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/6533b996c517430008c1206c
😎 Deploy Preview https://deploy-preview-1323--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexkrolick
Copy link
Collaborator

@MatanBobi looks pretty good to me, what do you think?

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoyelJohny, thanks for taking the time to work on this.
As an idea, I like this change but I left a few comments regarding the implementation.

@JoyelJohny
Copy link
Contributor Author

If there is any need for changes ,Please tell me 😄

@MatanBobi
Copy link
Member

That's great, thanks!

@MatanBobi MatanBobi merged commit b1c4ae9 into testing-library:main Oct 21, 2023
@MatanBobi
Copy link
Member

@all-contributors please add @JoyelJohny for code.

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @JoyelJohny! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants