fix(UMD path): Find dom-library with require.resolve #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Find the UMD path using
require.resolve
instead of using a using a relative path based on the current working directory.Detailed explanation
This enables support for monorepo projects. Many (dev)Dependencies in eg. Yarn Workspaces are installed in the
node_modules
folder in the root of the monorepo even if they are described in apackage.json
of a single workspace. A workspace might start a TestCafé test, initiated from the workspace folder eg.<root-of-monorepo>/packages/<workspace-folder>
. Here, the functionality of this package break because it determines theUMD_PATH
starting from the current working directory.I added an extra unit test
npm run test:unit:monorepo
to simulate a monorepo environment a.k.a. starting the process in another folder than where the node_modules folder is found.The original error can be recreated by running the
npm run test:unit:monorepo
without the applied fix.Closes #17
I'm happy to hear your feedback!