Error with `within` due to transpilation error

[leosuncin]

I can not use within query because it throw an exception as see bellow:

1) SyntaxError: missing ) after argument list

      Browser: Firefox 66.0.0 / Linux 0.0.0

         44 |      return DomTestingLibrary.${queryName}(document.body, ...arguments);
         45 |      `));
         46 |});
         47 |
         48 |const within = async sel => {
       > 49 |  await (0, _testcafe.ClientFunction)(new Function(` 
         50 |    const elem = document.querySelector("${sel}");
         51 |    window.TestCafeTestingLibrary["within_${sel}"] = DomTestingLibrary.within(elem);
         52 |
         53 |    `))();
         54 |  const container = {};

         at within (/home/user/contact-list/node_modules/testcafe-testing-library/dist/index.js:49:39)
         at  (/home/user/contact-list/tests/testcafe/test.spec.js:47:58)
         at step (/home/user/contact-list/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
         at  (/home/user/contact-list/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13)
         at $$testcafe_test_run$$ZaCadmd6U$$ (/home/user/contact-list/node_modules/testcafe/src/api/test-run-tracker.js:76:16)
         at $$testcafe_test_run$$ZaCadmd6U$$ (/home/user/contact-list/node_modules/testcafe/src/api/test-run-tracker.js:76:16)



 1/1 failed (8s)

Reproduce error with this repository: https://github.com/leosuncin/contact-list/tree/testcafe-testing-library_issue-15

Other Info:
testcafe-testing-library: 1.1.1
testcafe: 1.1.4
OS: Manjaro Linux 4.19
Node: 11.14.0
Firefox: 66.0.5
Chrome: 76.0.3783

[benmonro]

🎉 This issue has been resolved in version 1.1.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[benmonro]

@leosuncin thank you for A) using testcafe-testing-library and B) submitting this bug report. 🙏

Wanted to let you know that in order to use within you have to destructure the queries like this:

const {getByText} = await within('form[name="contact"]')

//or if that's colliding w/ the outter scope you can do:


const form = await within('form[name="contact"]');
expect(form.getByText("Foo"));

or else it will be bound to the default element which is document.body

that said, when I reproduced the issue locally, simply removing the within call on your branch made the test pass, so you may not even need it. but regardless, thanks again for submitting the bug and it's now fixed in 1.1.2. 😄

[leosuncin]

Question: Just works with string selector or can I use Selector from testcafe?

[benmonro]

Just string for now. But I'd love a pull request.

On Wed, May 8, 2019 at 3:01 PM Jaime Leonardo Suncin Cruz < ***@***.***> wrote: Question: Just works with string selector or can I use Selector from testcafe? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBPBAROPPFGNHAW5UZJT3PUNESNANCNFSM4HLVEN6Q> .

-- Ben Monro Software Developer

[leosuncin]

OK

[leosuncin]

Thanks for reply