Skip to content

fix(types): fix types when using legacy components in Svelte 5 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix(types): fix types when using legacy components in Svelte 5 #424

merged 1 commit into from
Feb 11, 2025

Conversation

mcous
Copy link
Collaborator

@mcous mcous commented Feb 11, 2025

Uncovered two issues with the render return types when using Svelte 5 with legacy (non-runes) components:

  • The render function should accept events as an option
  • The returned component should not have $set, $on, nor $destroy methods, which will error at runtime

@mcous mcous marked this pull request as ready for review February 11, 2025 17:56
@mcous mcous merged commit e86dada into main Feb 11, 2025
28 checks passed
@mcous mcous deleted the fix/legacy-types-in-svelte-5 branch February 11, 2025 17:59
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcous