Skip to content

TypeScript definition of act() function allows Promise as a parameter, but code fails if Promise is provided #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cbxp opened this issue Apr 12, 2021 · 1 comment · Fixed by #288
Closed

TypeScript definition of act() function allows Promise as a parameter, but code fails if Promise is provided #134

cbxp opened this issue Apr 12, 2021 · 1 comment · Fixed by #288
Labels
released

Comments

@cbxp
Copy link

cbxp commented Apr 12, 2021 •
edited
Loading

svelte-testing-library/src/pure.js

Line 94 in 5ae96a7

const value = fn && fn()

The code above should check if fn is a function before calling it, otherwise should be used as a Promise
@mcous mcous mentioned this issue Jan 24, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 4.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): correct type annotation for act
1 participant
@cbxp