fix: preact does not export Element

[maxbeatty]

What: bug in types. preact does not export Element

Why: causing issues in TypeScript project (and errors with eslint)

How: remove type declaration and depend on global Element

Checklist:

• Documentation added
• Tests
• Typescript definitions updated
• Ready to be merged
  

[JoviDeCroock]

Element is exported by the JSX bindings only, is it found as a global when you remove the import? https://github.com/preactjs/preact/blob/master/src/jsx.d.ts#L29

[maxbeatty]

my project is using:

• "typescript": "^4.7.3",
• "preact": "^10.7.3",

with v3.2.1, I'm seeing this error:

❯ tsc
node_modules/@testing-library/preact/types/index.d.ts:3:41 - error TS2305: Module '"preact"' has no exported member 'Element'.

3 import { ComponentChild, ComponentType, Element } from 'preact'

downgrading to v3.1.2 fixes the error. I was also able to verify by manually removing the Element import.

to your point, maybe a more appropriate fix is something like:

- import { ComponentChild, ComponentType, Element } from 'preact'
+ import { ComponentChild, ComponentType, JSX } from 'preact'

export * from '@testing-library/dom'

export type RenderResult<Q extends Queries = typeof queries> = {
-  container: Element
+  container: JSX.Element

[JoviDeCroock]

if it compiles with it removed (and finds it globally) that's good for me as well but yeah if we can use JSX.Element could be more appropriate😅

[maxbeatty]

actually, I think this should be a global Element to satisfy @testing-library/dom

import { render, fireEvent } from '@testing-library/preact';

// container is type Element
const { container } = render(<ExampleComponent />)

// fireEvent expects element to be Document | **Element** | Window | Node
fireEvent(container, new Event('example')

[github-actions]

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀