Skip to content

chore(deps): update typescript to v3 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020
Merged

chore(deps): update typescript to v3 #27

merged 1 commit into from
Mar 12, 2020

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Mar 11, 2020

  • Update tslint and fix some new linting issues
  • Set some linting that should probably be cleaned up as warnings
  • Updated wait-for-expect to fix resolve import lint complaint

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @abraham!

Updated wait-for-expect to fix resolve import lint complaint

oof, really wish we could've batched this with the previous breaking change 😆I'm not sure it's worth shipping another major for lint issues. Maybe we only ignore the lint error for now instead?

@abraham
Copy link
Contributor Author

abraham commented Mar 11, 2020

Maybe this should be bundled with #7 as I think that has a major update to testing-library core.

@patrickhulce
Copy link
Collaborator

Maybe this should be bundled with #7 as I think that has a major update to testing-library core.

By "this" do you mean the wait-for-expect update? If so, sounds great!

I still think we can do the typescript upgrade.

@abraham
Copy link
Contributor Author

abraham commented Mar 11, 2020

Yep, I'll update this PR later tonight.

@abraham
Copy link
Contributor Author

abraham commented Mar 11, 2020

@patrickhulce updated

@patrickhulce patrickhulce merged commit 2a920e1 into testing-library:master Mar 12, 2020
@abraham abraham deleted the typescript branch March 12, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants