Skip to content

Add findBy* async polling queries from @testing-library/dom #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexkrolick opened this issue Sep 27, 2018 · 3 comments · Fixed by #44
Closed

Add findBy* async polling queries from @testing-library/dom #7

alexkrolick opened this issue Sep 27, 2018 · 3 comments · Fixed by #44
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alexkrolick
Copy link

It would be pretty handy if pptr-testing-libary supported https://github.com/alexkrolick/dom-testing-addon-async

Basically, it adds Cypress-like functionality to queries by automatically retrying them until a timeout, and is async by default

@patrickhulce
Copy link
Collaborator

Ah interesting so it wraps everything in waitFor automatically? I'm not opposed to it but wouldn't want to greatly complicate the integration and update story. As you can tell, I'm not actively adding/upkeeping functions I'm not using myself :)

@MynockSpit
Copy link

Am I right in thinking that this (findBy* and findAllBy*) is now part of DTL core? The docs seem to imply that.

@patrickhulce
Copy link
Collaborator

They are part of dom-testing-library core now, so we should be able to handle this better within pptr-testing-library now 👍

@patrickhulce patrickhulce changed the title Add async polling queries Add findBy* async polling queries from @testing-library/dom Feb 27, 2020
@patrickhulce patrickhulce added enhancement New feature or request help wanted Extra attention is needed labels Feb 27, 2020
@umpox umpox mentioned this issue Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants