Skip to content

refactor: fix ts-expect-error #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2024
Merged

refactor: fix ts-expect-error #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b7a7cd
refactor: fix ts-expect-error
Belco90 Jan 14, 2024
d53fe8f
test: increase coverage
Belco90 Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/rules/no-await-sync-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ export default createTestingLibraryRule<Options, MessageIds>({
property.id.name === 'delay' &&
isLiteral(property.init) &&
property.init.value &&
// @ts-expect-error -- TODO: fix me
property.init.value > 0
Number.isInteger(property.init.value) &&
Number(property.init.value) > 0
);
},
AssignmentExpression(node: TSESTree.AssignmentExpression) {
Expand All @@ -89,8 +89,8 @@ export default createTestingLibraryRule<Options, MessageIds>({
isLiteral(node.right) &&
node.right.value !== null
) {
// @ts-expect-error -- TODO: fix me
hasDelayDeclarationOrAssignmentGTZero = node.right.value > 0;
hasDelayDeclarationOrAssignmentGTZero =
Number.isInteger(node.right.value) && Number(node.right.value) > 0;
}
},
'AwaitExpression > CallExpression'(node: TSESTree.CallExpression) {
Expand Down Expand Up @@ -143,8 +143,8 @@ export default createTestingLibraryRule<Options, MessageIds>({
property.key.name === 'delay' &&
isLiteral(property.value) &&
!!property.value.value &&
// @ts-expect-error -- TODO: fix me
property.value.value > 0
Number.isInteger(property.value.value) &&
Number(property.value.value) > 0
);

const simulateEventFunctionName = simulateEventFunctionIdentifier.name;
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/no-await-sync-events.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@ ruleTester.run(RULE_NAME, rule, {
code: `() => {
await userEvent.type(element, 'bar', {delay: 1234})
}
`,
},
{
code: `() => {
await userEvent.type(element, 'bar', {delay: null})
}
`,
},
{
Expand All @@ -155,6 +161,13 @@ ruleTester.run(RULE_NAME, rule, {
const delay = 10
await userEvent.keyboard('foo', {delay})
}
`,
},
{
code: `async() => {
const delay = null
await userEvent.keyboard('foo', {delay})
}
`,
},
{
Expand Down