Skip to content

chore: update dependencies #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2022
Merged

chore: update dependencies #691

merged 2 commits into from
Nov 20, 2022

Conversation

MichaelDeBoey
Copy link
Member

Will fix ESLint errors in #690

@MichaelDeBoey MichaelDeBoey added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 20, 2022
@MichaelDeBoey MichaelDeBoey mentioned this pull request Nov 20, 2022
Merged
3 tasks
@Belco90
Copy link
Member

Belco90 commented Nov 20, 2022

I don't get why we have new lint errors out of the blue. I suspect it's because unpinned dependencies. This happened many times before already, so I'm in favor of pinning dependencies once and for all.

@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Nov 20, 2022 •
edited
Loading

@Belco90 It seems that this is because there was a bug in the prefer-optional-chain rule, which is now fixed
@typescript-eslint/eslint-plugin isn't as strict as we are with this plugin either.

@Belco90
Copy link
Member

Belco90 commented Nov 20, 2022

@MichaelDeBoey so it's definitely caused by not pinning our dependencies. I'll merge this to avoid blocking other PRs and create an issue to tackle the pinning dependencies topic.

@Belco90 Belco90 merged commit dbb5889 into main Nov 20, 2022
@Belco90 Belco90 deleted the update-dependencies branch November 20, 2022 03:42
@github-actions
Copy link

🎉 This PR is included in version 6.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @Belco90 @bmish