Lists elements that matched multiple error

[jacobparis]

What:

This PR adds the found elements to the log output of the MultipleError

Current error

TestingLibraryElementError: Found multiple elements with the role "definition"

New error

TestingLibraryElementError: Found multiple elements with the role "definition"
    <dd
      aria-labelledby="uid-4-propertyValue"
      class="mb-0 text-size-large"
    >
      565000           
    </dd>
    <dd
      aria-labelledby="uid-4-appraisedValue"
      class="mb-0 text-size-large"
    >
      None         
    </dd>
    <dd
      aria-labelledby="uid-4-appraisedValue"
      class="mb-0 text-size-large"
    >
      2240 sqft         
    </dd>

Why:

It's not always immediately obvious which elements are conflicting, and since dom-testing-library needs to find them in order to know there are multiples it makes sense to expose that to the user

How:

I'm quite certain this is not the correct implementation of this feature, but I wanted to trial it out before investing too much time. If it's something deemed worthy of inclusion, I'd appreciate a little guidance on how to structure this (possibly a new wrapQuery type function) in a way that's idiomatic to the codebase

Checklist:

• Documentation added to the
  docs site N/A
• Tests
• Typescript definitions updated N/A
• Ready to be merged
  

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca6ceb3:

Sandbox	Source
agitated-darkness-kgkbj	Configuration

[codecov]

Codecov Report

Merging #678 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #678   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          602       603    +1     
  Branches       151       151           
=========================================
+ Hits           602       603    +1     

Impacted Files	Coverage Δ
src/query-helpers.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c262fd...ca6ceb3. Read the comment docs.

[kentcdodds]

I definitely feel like this would improve the error message. I'd love to find a way to do it that is backwards compatible. We can improve the API in the next major version bump.

[jacobparis]

I think ideally it belongs in the getMultipleElementsFoundError function, but since that requires an API change, directly in makeSingleQuery is the next best place

I've pushed that change (no longer breaking) and an accompanying test

[kentcdodds]

Love it 👍

[kentcdodds]

I think your other PR triggered merge conflicts. Could you fix those please?

[jacobparis]

Wow git really mangled those together

All resolved now 🙏

[kentcdodds]

Awesome 👍

[kentcdodds]

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

[kentcdodds]

🎉 This PR is included in version 7.19.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀