feat(createEvent): make a function that allows creating generic events #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b69732f:
|
kentcdodds
force-pushed
the
pr/create-event-function
branch
2 times, most recently
from
811b0de to
38def37
Compare
kentcdodds
force-pushed
the
pr/create-event-function
branch
from
38def37 to
b69732f
Compare
|
🎉 This PR is included in version 7.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: feat(createEvent): make a function that allows creating generic events
Why: So people can create generic events. Specifically needed for certain events that user-event needs to dispatch (like the change and input events when selecting a file).
How: take the function that was created for each
createEventand move it to a paramatarized function.Checklist:
docs site: Update api-events.md testing-library-docs#501