fix(types): add fourth param to build findAllBy and findBy queries

[mzdunek93]

Fixes #534

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a9be5f:

Sandbox	Source
musing-firefly-g3luo	Configuration

[codecov]

Codecov Report

Merging #574 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #574   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          462       462           
  Branches       114       114           
=========================================
  Hits           462       462           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcad11b...5a9be5f. Read the comment docs.

[eps1lon]

Looks good. Would you be so kind and add a test to types/__tests__/type-tests.ts so that we know this is fixed and won't regress?

[mzdunek93]

@eps1lon Sure.

[eps1lon]

@mzdunek93 Awesome! Very nice test.

[eps1lon]

@all-contributors add @mzdunek93 for code

[allcontributors]

@eps1lon

I've put up a pull request to add @mzdunek93! 🎉

[kentcdodds]

🎉 This PR is included in version 7.5.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[denysdovhan]

This PR makes those arguments required. They should be optional. @kentcdodds should I open another issue?

[kentcdodds]

Sure. Or you could open a PR of it's simple

[zorfling]

@denysdovhan - did this one ever get fixed? It looks like they're still required in master?
https://github.com/testing-library/dom-testing-library/blob/master/types/query-helpers.d.ts#L42

[denysdovhan]

@zorfling it's still relevant. Now the fourth argument of findAllBy and findBy is required. It should be optional.

[zorfling]

@denysdovhan I've added #794, so hopefully we'll get this one fixed soon.