ComponentProperties no longer in ngOnChanges

[swhammack]

After updating to 10.4.0 we saw a bunch of tests that were suddenly failing. After a bit of digging I realized each component implemented OnChanges and in the ngOnChanges() function we were looking for an @Input property to be in the changes object. It seems with the latest changes any @Input property that is set in componentProperties is never in the changes object in ngOnChanges.

Quick example:

@Component
class Component implements OnChanges {
  @Input() someProperty: string

  ngOnChanges(changes: SimpleChanges) {
    if(changes.someProperty) {
      // Do something if @Input property changed
    }
  }
}

render(Component, {
  componentProperties: {someProperty: 'value'}
})

[timdeschryver]

Thanks for the report!
Could you create a reproduction for this behavior, or take a look at how we can fix this in ATL?
I thought we had a test case for this, but it seems like it isn't covering everything 😅

[swhammack]

Here is my fork with a reproduction test.

[timdeschryver]

Thanks a lot @swhammack !

[github-actions]

🎉 This issue has been resolved in version 10.4.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[swhammack]

@timdeschryver thanks for the quick fix!