Skip to content

fix(keycloak): tests on aarch64, use image from [jboss -> quay], change supported version [16+ -> 18+] #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderankin merged 1 commit into from
Mar 21, 2024
Merged

fix(keycloak): tests on aarch64, use image from [jboss -> quay], change supported version [16+ -> 18+] #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions modules/keycloak/testcontainers/keycloak/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,21 @@ class KeycloakContainer(DockerContainer):

def __init__(
self,
image="jboss/keycloak:latest",
image="quay.io/keycloak/keycloak:latest",
username: Optional[str] = None,
password: Optional[str] = None,
port: int = 8080,
) -> None:
super().__init__(image=image)
self.username = username or os.environ.get("KEYCLOAK_USER", "test")
self.password = password or os.environ.get("KEYCLOAK_PASSWORD", "test")
self.username = username or os.environ.get("KEYCLOAK_ADMIN", "test")
self.password = password or os.environ.get("KEYCLOAK_ADMIN_PASSWORD", "test")
self.port = port
self.with_exposed_ports(self.port)

def _configure(self) -> None:
self.with_env("KEYCLOAK_USER", self.username)
self.with_env("KEYCLOAK_PASSWORD", self.password)
self.with_env("KEYCLOAK_ADMIN", self.username)
self.with_env("KEYCLOAK_ADMIN_PASSWORD", self.password)
self.with_command("start-dev")

def get_url(self) -> str:
host = self.get_container_host_ip()
Expand All @@ -58,8 +59,7 @@ def get_url(self) -> str:

@wait_container_is_ready(requests.exceptions.ConnectionError, requests.exceptions.ReadTimeout)
def _connect(self) -> None:
url = self.get_url()
response = requests.get(f"{url}/auth", timeout=1)
response = requests.get(self.get_url(), timeout=1)
response.raise_for_status()

def start(self) -> "KeycloakContainer":
Expand All @@ -70,7 +70,7 @@ def start(self) -> "KeycloakContainer":

def get_client(self, **kwargs) -> KeycloakAdmin:
default_kwargs = {
"server_url": f"{self.get_url()}/auth/",
"server_url": self.get_url(),
"username": self.username,
"password": self.password,
"realm_name": "master",
Expand Down
9 changes: 3 additions & 6 deletions modules/keycloak/tests/test_keycloak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import pytest

from testcontainers.keycloak import KeycloakContainer


@pytest.mark.parametrize("version", ["16.1.1"])
def test_docker_run_keycloak(version: str):
with KeycloakContainer(f"jboss/keycloak:{version}") as kc:
kc.get_client().users_count()
def test_docker_run_keycloak():
with KeycloakContainer("quay.io/keycloak/keycloak:24.0.1") as keycloak_admin:
keycloak_admin.get_client().users_count()