fix: adds checks for missing properties #1104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahennr
reviewed
Jul 6, 2023
| const size = getWidth(projectionExtent) / 256; | ||
| const resolutions = new Array(19); | ||
| const matrixIds = new Array(19); | ||
| for (let z = 0; z < 19; ++z) { |
There was a problem hiding this comment.
Suggested change
| for (let z = 0; z < 19; ++z) { | |
| for (let z = 0; z < 19; z++) { |
You need to increment after the statements in the loop are made, don't you?
There was a problem hiding this comment.
I think in that particular case it does not really matter, both variants seem to work.
ahennr
reviewed
Jul 6, 2023
|
|
||
| const projectionExtent = projection.getExtent(); | ||
| const size = getWidth(projectionExtent) / 256; | ||
| const resolutions = new Array(19); |
There was a problem hiding this comment.
You assume that always 19 Matrix levels are available in tile grid definition?
There was a problem hiding this comment.
I got this part from the OpenLayers Examples but you are right, the array could always be different!
| }); | ||
| }; | ||
|
|
||
| if (layer.source.style) { |
There was a problem hiding this comment.
Minor: You could also write
const style = layer?.source?.style ?? 'default'
instead of the if-else block
There was a problem hiding this comment.
Yes that looks way more clean thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WMTS Layer with missing properties could not be displayed. Adds a check for missing properties.
Related issues or pull requests
Pull request type
Do you introduce a breaking change?