Support provider-defined functions in JSON syntax #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #214
#214 cannot find provider-defined function calls in JSON syntax because it implicitly assumes the expression to be
hclsyntax.FunctionCallExprwhen walking expressions.This PR fixes it to find function calls by taking advantage of the fact that evaluating a JSON syntax expression in a nil context always results in a template string that can be parsed in native syntax. This is the same logic used to find function calls in TFLint.
https://github.com/terraform-linters/tflint/blob/v0.53.0/terraform/lang/function_calls.go#L21
Given the fact that this logic is reusable in this rule, it might be worth providing it as an SDK API, but that's outside the scope here.