terraform_unused_declarations: Make unused variable checks aware of validation blocks #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
deleted the
make_unused_variable_check_aware_of_validation_blocks
branch
tpdownes
added a commit
to tpdownes/cluster-toolkit
that referenced
this pull request
Dec 5, 2023
Use older release until we address the code changes required by terraform-linters/tflint-ruleset-terraform#133
ek-nag
pushed a commit
to ek-nag/hpc-toolkit
that referenced
this pull request
Dec 8, 2023
Use older release until we address the code changes required by terraform-linters/tflint-ruleset-terraform#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
The
terraform_unused_declarationsrule recognizes unused variables by walking through all expressions and seeing if a variable reference exists. However, this way cannot recognize which block is being walked, so false negatives like #94 may occur.This PR changes the rule so that if an expression reference is inside a variable validation block, it will not be marked as used.