aws_iam_policy_sid #155
Merged
aws_iam_policy_sid #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int-ruleset-aws#149
wata727
reviewed
Aug 9, 2021
| return err | ||
| } | ||
| policy := unMarshaledPolicy.(map[string]interface{}) | ||
| statements := policy["Statement"].([]interface{}) |
Member
There was a problem hiding this comment.
Casting interface{} can cause panic. In this case, it's a good idea to declare a structure for the policy and unmarshal it there.
https://gobyexample.com/json
| if r.validCharacters.MatchString(statement["Sid"].(string)) == false { | ||
| runner.EmitIssueOnExpr( | ||
| r, | ||
| "The policy's sid contains invalid characters.", |
Member
There was a problem hiding this comment.
The error message should clearly indicate why it is invalid. Perhaps it would be nice to include a regexp pattern.
Contributor
Author
|
@wata727 those should be fixed. Thank you for the feedback. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add invalid sid rules fixes #149
This should loop through all SIDs in a policy and make sure all of them fit the pattern.