-
Notifications
You must be signed in to change notification settings - Fork 2
feat: backup_id #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backup_id #51
Conversation
vburckhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I put a few comments inline.
I'd also suggest adding a new example using the backup. For instance, you could try to create a postgres instance, use https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/data-sources/database_backups to fetch list of backup, pick one of them at random to create a new instance. Or more simply (but less valuable for consumers), point to an existing long running postgres instance in the test account.
…-icd-postgresql into backup-support
…raform-ibm-icd-postgresql into backup-support
|
@vburckhardt Pointing to the backup creation done. That's how it looks in the UI (See Recent tasks tab) In the example, the user can provide an existing Also, added |
vburckhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - a few more comments.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |

Description
backup_id support
Types of changes in this PR
No release required
Release required
x.x.X): Change that fixes an issue and is compatible with earlier versions)x.X.x): Change that adds functionality and is compatible with earlier versions)X.x.x): Change that is likely incompatible with previous versions)Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.
Checklist for reviewers
Merge actions for mergers
Merge by using "Squash and merge".
Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).