Skip to content

Conversation

@rajatagarwal-ibm
Copy link
Member

@rajatagarwal-ibm rajatagarwal-ibm commented Mar 5, 2023

Description

backup_id support

Types of changes in this PR

No release required

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other changes that don't affect Terraform code

Release required

  • Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
  • New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
  • Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)
Release notes content

Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.


Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Merge by using "Squash and merge".

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.

    The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

@vburckhardt vburckhardt self-requested a review March 6, 2023 12:49
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I put a few comments inline.

I'd also suggest adding a new example using the backup. For instance, you could try to create a postgres instance, use https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/data-sources/database_backups to fetch list of backup, pick one of them at random to create a new instance. Or more simply (but less valuable for consumers), point to an existing long running postgres instance in the test account.

@rajatagarwal-ibm
Copy link
Member Author

rajatagarwal-ibm commented Mar 8, 2023

@vburckhardt Pointing to the backup creation done. That's how it looks in the UI (See Recent tasks tab)
image

In the example, the user can provide an existing backup_crn or create a fresh instance of PostgreSQL DB, then it would create a new PostgreSQL DB instance which points to the backup_crn, which basically covers both the points you have mentioned.

Also, added other_test.go to run the "restored" example in the continuous tests only, as it creates 2 instances back to back which could take more than an hour. Also, this module has 4 examples already running in the PR pipeline.

Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - a few more comments.

@vburckhardt vburckhardt self-requested a review March 9, 2023 13:08
@vburckhardt vburckhardt merged commit 649583c into main Mar 9, 2023
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rajatagarwal-ibm rajatagarwal-ibm deleted the backup-support branch March 9, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants