feat: Add ability to supply vpc_id along with endpoint creation #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Excluded non-subnet dependent endpoints from proposed changes. Will be updating PR shortly. |
polymorcodeus
changed the title
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding functionality to use existing VPC to create endpoints. Added two new variables, vpc_id and use_existing_vpc_id_for_endpoints, as well as adding conditional creation for the endpoints based on their input. If both of the new variables are ignored/left to default, no existing module functionality should be affected.
Motivation and Context
Allows module to be used with an existing VPC to create endpoints not using the default security group. Also solves the circular reasoning issue below, allowing creation of a VPC, then the endpoint security group, then the endpoints.
#332
Breaking Changes
Not that I've seen.
How Has This Been Tested?
Tested example code, providing two ids listed in variables doc.
Unable to get test-kitchen working on my mac to run the tests in the repo. Apologies.