adding option to create a route to nat gateway in database subnets #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@antonbabenko any feedback? |
antonbabenko
requested changes
Jan 18, 2019
Member
antonbabenko
left a comment
antonbabenko
left a comment
There was a problem hiding this comment.
Looks pretty good. Small syntax fix is required.
ebarault
force-pushed
the
feat/database-route-to-natgw
branch
from
2de371a to
0160116
Compare
Contributor
Author
|
@antonbabenko arff you're right, sorry about that, i just pushed the fix, please have a look |
Member
|
Thank you, Eric! v1.53.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
create_database_internet_gateway_route, this adds thecreate_database_nat_gateway_routeparameter to create routes in database subnets to the unique/per-AZ/per-subnet NAT Gateways.