Skip to content

feat: Enhancing VPC Security with Amazon VPC Block Public Access #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 12, 2025
Merged

feat: Enhancing VPC Security with Amazon VPC Block Public Access #1159

merged 17 commits into from
Feb 12, 2025

Conversation

@sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Jan 26, 2025 •
edited
Loading

Description

PR add support for VPC Block Public Access exclusions and VPC Block Public Access options

Motivation and Context

Resolves #1158

Breaking Changes

It doesn't break backwards compatibility with the current major version

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

antonbabenko
antonbabenko requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, there are a few comments.

antonbabenko
antonbabenko requested changes Jan 28, 2025
View reviewed changes
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Feb 3, 2025

@antonbabenko thanks for your comments, I fixed all of them. If you could take a look once again, I will be grateful. Thanks.

@garym-krrv
Copy link

garym-krrv commented Feb 11, 2025

Commenting to track PR. Keen to start using this in the module

Thanks All

@antonbabenko antonbabenko merged commit 387f5ee into terraform-aws-modules:master Feb 12, 2025
19 checks passed
@antonbabenko
Copy link
Member

antonbabenko commented Feb 12, 2025

Thank you for the contributions @sebastianczech !

antonbabenko pushed a commit that referenced this pull request Feb 12, 2025
@semantic-release-bot
chore(release): version 5.19.0 [skip ci]
961c9b5 
## [5.19.0](v5.18.1...v5.19.0) (2025-02-12)

### Features

* Enhancing VPC Security with Amazon VPC Block Public Access ([#1159](#1159)) ([387f5ee](387f5ee))
@antonbabenko
Copy link
Member

antonbabenko commented Feb 12, 2025

This PR is included in version 5.19.0 🎉

@garym-krrv
Copy link

garym-krrv commented Feb 12, 2025

Going to need a change to the module. Unable to set the Name on the bpa exclusion. I will take a look

@sebastianczech sebastianczech deleted the feat/block-public-access-exclusion-1158 branch February 12, 2025 18:14
@sebastianczech sebastianczech mentioned this pull request Feb 19, 2025
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Mar 15, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for VPC Block Public Access exclusions

3 participants

@sebastianczech @garym-krrv @antonbabenko