Deprecate vpc_classic_link

[marcofranssen]

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

• Yes ✅: 4.28.0

Is your request related to a problem? Please describe.

╷
│ Warning: Argument is deprecated
│ 
│   with module.vpc.aws_vpc.this,
│   on .terraform/modules/vpc/main.tf line 27, in resource "aws_vpc" "this":
│   27:   enable_classiclink               = var.enable_classiclink
│ 
│ With the retirement of EC2-Classic the enable_classiclink attribute has
│ been deprecated and will be removed in a future version.
│ 
│ (and 3 more similar warnings elsewhere)
╵

Describe the solution you'd like.

Implement a migration path once the classiclink is completely removed from the AWS provider.

Describe alternatives you've considered.

Additional context

Warning shows up since we bumped the AWS provider to 4.28.0.

[lorengordon]

Fyi, since this module is setting enable_classiclink to null by default, there is a chance this is a bug. I've opened an upstream issue. Please give it a 👍 !

hashicorp/terraform#31730

[bryantbiggs]

Thank you @lorengordon for that. While that is rather annoying, I'm leaning towards maybe just setting it to null on the argument here in the module. Some could view that as a breaking change, but since AWS made this decision and that is the direction (and I suspect it affects a very, very small segment of users), I'm inclined in making that change since it seems like the easiest path to resolution with the least disruption. @antonbabenko what do you think about setting

terraform-aws-vpc/main.tf

Line 27 in 78f2845

enable_classiclink = var.enable_classiclink

to a hardcoded null?

[lorengordon]

You might as well just remove the argument from the resource, in that case... It's the same effect to terraform and the provider and the users, and less code.

[lorengordon]

The harder "backwards incompatible" bit for this module, imo, would be the removal of the variable, var.enable_classiclink. Since for any user that is setting that variable in their config, even if false or null, they would then need to remove it to avoid an error when upgrading.

Certainly, users that are relying on that variable and setting it to true, they're going to run into an problem with that feature being deprecated at the AWS API. They've got some work anyway.

Anyway, just my two cents. I always pin module versions and test updates, so I'm happy as long as the deprecation warning goes away. 😛

[antonbabenko]

This issue has been resolved in version 3.14.4 🎉

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.