endpoints fail with terraform 0.12.29 (which is allowed) - cannot run plan&apply of complete example

[tbugfinder]

terraform-aws-vpc/modules/vpc-endpoints/main.tf

Line 2 in 73b447f

endpoints = var.create ? var.endpoints : tomap({})

$ terraform -version
Terraform v0.12.29

###

terraform init
terraform plan
Error: Inconsistent conditional result types

  on ../../modules/vpc-endpoints/main.tf line 2, in locals:
   2:   endpoints = var.create ? var.endpoints : tomap({})
    |----------------
    | var.create is true
    | var.endpoints is object with 14 attributes

The true and false result expressions must have consistent types. The given
expressions are object and map of dynamic, respectively.

[marcohenriques]

I'm also having this issue in terraform version 0.15.3 when using vpc-endpoints submodule

[rmchale]

I am also having this issue.

[tbugfinder]

I did some research on different options to fix this issue, however I couldn't find anything which just fixes above reported line of code for terraform 0.12.x, so the module would require additional changes.

I think maitainers should add some thought here, too. Do you want to drop terraform 0.12.x support or should for_each be rewritten for vpc_endpoints?

@bryantbiggs - any thoughts?

[dctrwatson]

Workaround adapted from complete example:

locals {
  endpoints = {
    s3 = {
      service = "s3"
      tags    = { Name = "s3-vpc-endpoint" }
    },
    dynamodb = {
      service         = "dynamodb"
      service_type    = "Gateway"
      route_table_ids = flatten([module.vpc.intra_route_table_ids, module.vpc.private_route_table_ids, module.vpc.public_route_table_ids])
      policy          = data.aws_iam_policy_document.dynamodb_endpoint_policy.json
      tags            = { Name = "dynamodb-vpc-endpoint" }
    },
    ssm = {
      service             = "ssm"
      private_dns_enabled = true
      subnet_ids          = module.vpc.private_subnets
    },
    ssmmessages = {
      service             = "ssmmessages"
      private_dns_enabled = true
      subnet_ids          = module.vpc.private_subnets
    },
  ]

  create_endpoints = false
}

module "vpc_endpoints" {
  source = "../../modules/vpc-endpoints"

  create = local.create_endpoints

  vpc_id             = module.vpc.vpc_id
  security_group_ids = [data.aws_security_group.default.id]
  
  endpoints = { for service, ep in local.endpoints : (service) => ep if local.create_endpoints }
  
  tags = merge(local.tags, {
    Project  = "Secret"
    Endpoint = "true"
  })
}

[ejimz]

Same here with v0.14.11

[SkypLabs]

Same issue with Terraform v1.0.1.

[bryantbiggs]

fixed in #729

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.