Feature request: "propagate_intra_route_tables_vgw"

[paullschock]

I am utilizing intra_subnets as a part of a use-case where I am exposing AWS services to a private (non-internet connected) network connected to AWS via a virtual gateway interface (by way of direct connect private vif) and would like to be able to optionally propagate learned routes to intra_subnets.

Following from how this is done for private subnets, I think the following would work (assuming additional variable added):

resource "aws_vpn_gateway_route_propagation" "intra" {
  count = "${var.create_vpc && var.propagate_intra_route_tables_vgw && (var.enable_vpn_gateway || var.vpn_gateway_id != "") ? length(var.intra_subnets) : 0}"

  route_table_id = "${element(aws_route_table.intra.*.id, count.index)}"
  vpn_gateway_id = "${element(concat(aws_vpn_gateway.this.*.id, aws_vpn_gateway_attachment.this.*.vpn_gateway_id), count.index)}"
}

Put together a more complete commit in a branch here paullschock@2da6b56

[DrFaust92]

@antonbabenko , does this make sense to you given the "closed" nature of the intra subnets? i can open a PR if you are ok with it.

[antonbabenko]

Yes, I think this is a valid case even for "closed" subnets as intra.

Please open PR only to the master branch. We need to stop adding new features for Terraform 0.11 users.

[DrFaust92]

Will do

…

On Tue, Mar 24, 2020, 20:18 Anton Babenko ***@***.***> wrote: Yes, I think this is a valid case even for "closed" subnets as intra. Please open PR only to the master branch. We need to stop adding new features for Terraform 0.11 users. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#352 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIA2W7TTUBC4GYTKSBNCOUTRJD2QJANCNFSM4JJRAHJA> .

[antonbabenko]

v2.32.0 of this module has been just released.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.