Skip to content

feat: Allow setting custom tags on aws_vpc_block_public_access_exclusion resource #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2025
Merged

feat: Allow setting custom tags on aws_vpc_block_public_access_exclusion resource #1170

merged 3 commits into from
Apr 21, 2025

Conversation

@garym-krrv
Copy link

@garym-krrv garym-krrv commented Feb 12, 2025 •
edited
Loading

Description

Allows name tagging on aws_vpc_block_public_access_exclusion resource

Closes #1169

Motivation and Context

To be able to set the name tag on the AWS resource
#1169

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@garym-krrv garym-krrv changed the title fix: define a Name tag on the aws_vpc_block_public_access_exclusion resource #1169 fix: Define a Name tag on the aws_vpc_block_public_access_exclusion resource #1169 Feb 12, 2025
@garym-krrv garym-krrv changed the title fix: Define a Name tag on the aws_vpc_block_public_access_exclusion resource #1169 fix: Define a Name tag on the aws_vpc_block_public_access_exclusion resource Closes #1169 Feb 13, 2025
sebastianczech
sebastianczech reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, I forgotten about Name tag in my PR #1159, so thanks for adding it 👍

@garym-krrv
Copy link
Author

garym-krrv commented Feb 20, 2025

Nice improvements, I forgotten about Name tag in my PR #1159, so thanks for adding it 👍

Thank you for adding the initial functionality @sebastianczech

Just a small tweak. Cheers

@garym-krrv
Copy link
Author

garym-krrv commented Mar 17, 2025

BUMP.. Needs approval

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 17, 2025
@garym-krrv
Copy link
Author

garym-krrv commented Apr 17, 2025

Not stale. Requires PR approval

@github-actions github-actions bot removed the stale label Apr 18, 2025
@bryantbiggs bryantbiggs changed the title fix: Define a Name tag on the aws_vpc_block_public_access_exclusion resource Closes #1169 feat: Allow setting custom tags on aws_vpc_block_public_access_exclusion resource Apr 21, 2025
@bryantbiggs bryantbiggs merged commit 0d11295 into terraform-aws-modules:master Apr 21, 2025
20 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 21, 2025
@semantic-release-bot
chore(release): version 5.20.0 [skip ci]
52de296 
## [5.20.0](v5.19.0...v5.20.0) (2025-04-21)

### Features

* Allow setting custom tags on `aws_vpc_block_public_access_exclusion` resource ([#1170](#1170)) ([0d11295](0d11295))
@antonbabenko
Copy link
Member

antonbabenko commented Apr 21, 2025

This PR is included in version 5.20.0 🎉

@github-actions
Copy link

github-actions bot commented May 22, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

+1 more reviewer

@sebastianczech sebastianczech sebastianczech left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to define a Name tag on the aws_vpc_block_public_access_exclusion resource

4 participants

@garym-krrv @antonbabenko @sebastianczech @bryantbiggs