Skip to content

Conversation

@bfqrst
Copy link
Contributor

@bfqrst bfqrst commented Apr 17, 2023

Description

The HashiCorp Consul team has spread the TLS and non-TLS config for gRPC over two distinct ports. A new port has been introduced, which is reflected in this PR.

Motivation and Context

https://github.com/hashicorp/consul/releases/tag/v1.14.0

Breaking Changes

None. This has been tested using the local branch.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bfqrst bfqrst changed the title feat(Consul): add gRPC_tls port for v1.14.x feat: Add gRPC_tls port for Consul v1.14.x Apr 17, 2023
@antonbabenko antonbabenko changed the title feat: Add gRPC_tls port for Consul v1.14.x feat!: Upgraded version of Terraform, AWS Provider, and added gRPC_tls port for Consul v1.14.x Jun 1, 2023
@antonbabenko
Copy link
Member

I understand that the PR is a bit too big, but it is necessary to get it through.

@antonbabenko antonbabenko merged commit 0093dca into terraform-aws-modules:master Jun 1, 2023
@antonbabenko
Copy link
Member

This PR is included in version 5.0.0 🎉

antonbabenko pushed a commit that referenced this pull request Jun 1, 2023
## [5.0.0](v4.17.2...v5.0.0) (2023-06-01)

### ⚠ BREAKING CHANGES

* Upgraded version of Terraform, AWS Provider, and added gRPC_tls port for Consul v1.14.x (#284)

### Features

* Upgraded version of Terraform, AWS Provider, and added gRPC_tls port for Consul v1.14.x ([#284](#284)) ([0093dca](0093dca))
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants