Skip to content

Conversation

@nohtyp
Copy link

@nohtyp nohtyp commented Dec 1, 2023

Description

I have created the variable route53_vpc_id to allow searching across vpcs for the hosted zone. The current data resource leaves this out and prevents lookups for hosted zones in a different vpc.

Motivation and Context

This change is required to allow searching across vpc's when your hosted zone is placed in a different vpc than where your current code runs.

Breaking Changes

This should not break any current configurations as this is referencing an existing object, and if not provided the default is null.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed the code within my environment and I am now able to create records
  • I have executed pre-commit run -a on my pull request

@nohtyp nohtyp closed this Dec 2, 2023
@github-actions
Copy link

github-actions bot commented Jan 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
@antonbabenko
Copy link
Member

This issue has been resolved in version 6.0.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants