fix: Cloudwatch Log Group deletion db_instance dependency #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magreenbaum
changed the title
magreenbaum
changed the title
magreenbaum
commented
Jul 25, 2022
| @@ -182,13 +174,13 @@ module "db" { | |||
|
|
|||
| # S3 import https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/MySQL.Procedural.Importing.html | |||
| s3_import = { | |||
| source_engine_version = "8.0.27" | |||
| bucket_name = aws_s3_bucket.import.id | |||
| source_engine_version = "8.0.28" | |||
| ingestion_role = aws_iam_role.s3_import.arn | ||
| } | ||
|
|
||
| multi_az = true | ||
| subnet_ids = module.vpc.database_subnets | ||
| db_subnet_group_name = module.vpc.database_subnet_group_name |
bryantbiggs
reviewed
Jul 25, 2022
| @@ -80,25 +80,17 @@ module "security_group" { | |||
| tags = local.tags | |||
| } | |||
|
|
|||
| # Temporary work around until S3 module is updated to support v4.x | |||
| resource "aws_s3_bucket" "import" { | |||
| module "import_s3_bucket" { | |||
bryantbiggs
approved these changes
Jul 25, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Jul 25, 2022
### [5.0.1](v5.0.0...v5.0.1) (2022-07-25) ### Bug Fixes * Cloudwatch Log Group deletion db_instance dependency ([#423](#423)) ([e6351a3](e6351a3))
|
This PR is included in version 5.0.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
depends_onso that the cloudwatch log groups are created before and destroyed after the db instance if creating cloudwatch log groups with this module.Fixed
example/s3-import-mysqlto include updated s3 module.Motivation and Context
#419
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request