feat: Add support for character_set_name with MSSQL Server #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alo-is
changed the title
antonbabenko
requested changes
Apr 16, 2020
There was a problem hiding this comment.
Thanks for the PR!
Few comments:
- Please add support to the same
character_set_nameinto the root module. - Update code in
examples/complete-mssqlexample with this feature.
PS: If your PR is working as you say, could you also open an issue in https://github.com/terraform-providers/terraform-provider-aws and/or update documentation for this argument there.
Thanks!
|
closed with #281 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for character_set_name (also known as collation) in Microsoft SQL Server on RDS. This feature is optional, but supported in MSSQL on RDS.
Motivation and Context
Without this attribute, newly created MSSQL databases on RDS will be set to SQL_Latin1_General_CP1_CI_AS, which is the default value, but is incorrect in some cases when specific charsets are used, or with some software (we've got the issue with Sage Accounting solution).
The full AWS documentation regarding this attribute is available here : https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.SQLServer.CommonDBATasks.Collation.html
Breaking Changes
No impact on current version, if is attribute is left empty, then default value will apply as before (set by AWS, not this module).
How Has This Been Tested?
This change has been tested by deploying MSSQL 2017 Servers on RDS (express + web version). With & without the attribute, the changes are working as expected, changing the database default collation to the wanted one.