MySQL replica example appears to be broken

[silviogutierrez]

First off: thanks for these modules, they're very helpful when navigating the AWS ecosystem.

The RDS mysql replica example, verbatim, currently fails with terraform 0.12.7.

Steps to reproduce:

1. git clone git@github.com:terraform-aws-modules/terraform-aws-rds.git
2. cd terraform-aws-rds/examples/replica-mysql
3. terraform init
4. terraform apply

module.replica.module.db_option_group.aws_db_option_group.this[0]: Creating...
module.master.module.db_option_group.aws_db_option_group.this[0]: Creating...
module.master.module.db_subnet_group.aws_db_subnet_group.this[0]: Creating...
module.master.module.db_subnet_group.aws_db_subnet_group.this[0]: Creation complete after 3s [id=demodb-master-mysql-20200720200939150700000003]


Error: Error creating DB Option Group: InvalidParameterValue: The parameter MajorEngineVersion must be provided and must not be blank.
        status code: 400, request id: e2973e1f-cb0b-49cf-835f-40ed9b3e7a77

  on ../../modules/db_option_group/main.tf line 1, in resource "aws_db_option_group" "this":
   1: resource "aws_db_option_group" "this" {



Error: Error creating DB Option Group: InvalidParameterValue: The parameter MajorEngineVersion must be provided and must not be blank.
        status code: 400, request id: c0a6ae89-97c3-40a2-87c7-09b9611b991a

  on ../../modules/db_option_group/main.tf line 1, in resource "aws_db_option_group" "this":
   1: resource "aws_db_option_group" "this" {

I tried to debug further but I'm not familiar enough with option groups. Hope this helps.

[yhkim-prestolabs]

terraform-aws-rds/main.tf

Line 9 in c1b7f12

enable_create_db_option_group = var.create_db_option_group ? true : var.option_group_name == "" && var.engine != "postgres"

I think var.option_group_name == "" should be var.option_group_name != "".

[tlecointre]

I'm getting the same error with create_db_option_group = false . The plan shows a option group creation and the apply fails with the same error as Silvio.

Module: 2.17.0
MySQL 8.0.15 for the RDS

[bryantbiggs]

hi all, we've gone through the examples and validated that they are all up to date and functional in #298

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.